Add feature derivator#771
Merged
typhoonzero merged 9 commits intosql-machine-learning:developfrom Sep 10, 2019
Merged
Conversation
tonyyang-svail
approved these changes
Sep 9, 2019
Collaborator
tonyyang-svail
left a comment
tonyyang-svail
left a comment
There was a problem hiding this comment.
LGTM. Please also test this on Hive.
Collaborator
Author
|
@tonyyang-svail Thanks for reminding, will add test on hive in next PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of work: #705