Skip to content

Fix develop branch build fail#803

Merged
typhoonzero merged 3 commits intosql-machine-learning:developfrom
typhoonzero:feature_derivation_hive_test
Sep 10, 2019
Merged

Fix develop branch build fail#803
typhoonzero merged 3 commits intosql-machine-learning:developfrom
typhoonzero:feature_derivation_hive_test

Conversation

@typhoonzero
Copy link
Copy Markdown
Collaborator

@typhoonzero typhoonzero commented Sep 10, 2019 •
edited
Loading

seems shap==0.30.1 depends on dill but shap does not include dill as it's dependency causing the shap package broken.

need to remote pip install dill when shap fixes this.

@typhoonzero typhoonzero changed the title debug develop CI fail Fix develop branch build fail Sep 10, 2019
Yancey0623
Yancey0623 reviewed Sep 10, 2019
View reviewed changes
Comment thread sql/codegen.go Outdated
Yancey0623
Yancey0623 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 5653d09 into sql-machine-learning:develop Sep 10, 2019
@typhoonzero typhoonzero deleted the feature_derivation_hive_test branch September 10, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yancey0623 Yancey0623 Yancey0623 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@typhoonzero @Yancey0623