Add intermediate representation struct #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Sep 11, 2019
tonyyang-svail
force-pushed
the
add_intermediate_represenstation
branch
from
7b93975 to
d52d55b
Compare
tonyyang-svail
commented
Sep 12, 2019
typhoonzero
approved these changes
Sep 13, 2019
Collaborator
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM, please add a function in type FeatureColumn interface{} to garantee the FeatureColumn types.
Collaborator
Author
Here is nice blog posting listing possible alternatives for sum types in Go. https://making.pusher.com/alternatives-to-sum-types-in-go/ I vote for alternativ#1, in our case, we can add a |
Collaborator
|
@tonyyang-svail Agree! Seems nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #809