Fix #3 and Tests #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix issue #3, removing the error that is thrown when an event has no subscribers. During this fix, I also noticed that several tests were written using the bind() function, like so:
expect(pubService.$sub.bind(undefined)).toThrow();This syntax binds the
thiskeyword of the function toundefined. I believe the intent here was to passundefinedas the first argument to the function. To fix this issue, I replaced the test with arrow functions:expect(() => pubService.$sub(undefined)).toThrow();This syntax should correctly pass
undefinedas theeventargument of the$submethod.