Skip to content

Fix missing None handling of Table.prefixes#6672

Closed
kasium wants to merge 2 commits intosqlalchemy:masterfrom
kasium:issue-867
Closed

Fix missing None handling of Table.prefixes#6672
kasium wants to merge 2 commits intosqlalchemy:masterfrom
kasium:issue-867

Conversation

@kasium
Copy link
Copy Markdown
Contributor

@kasium kasium commented Jun 24, 2021

Resolves https://github.com/sqlalchemy/alembic/issues/867

Description

Table misses a None handling of prefixes

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@CaselIT CaselIT requested a review from sqla-tester June 24, 2021 13:53
Copy link
Copy Markdown
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 0638723 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Copy Markdown
Collaborator

New Gerrit review created for change 0638723: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2893

@CaselIT CaselIT requested a review from sqla-tester June 24, 2021 15:57
Copy link
Copy Markdown
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision b79aca0 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Copy Markdown
Collaborator

Patchset b79aca0 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2893

@kasium
Copy link
Copy Markdown
Contributor Author

kasium commented Jun 24, 2021

@CaselIT can you please take a look into the test errors. They seem to be unrelated to my change
DatabaseError: (cx_Oracle.DatabaseError) ORA-12519: TNS:no appropriate service handler found

@CaselIT
Copy link
Copy Markdown
Member

CaselIT commented Jun 24, 2021

sure, no problem. Mike probably needs to reboot oracle :)

@zzzeek
Copy link
Copy Markdown
Member

zzzeek commented Jun 24, 2021

when CI is quiet today I'll rebuild all the MSSQL and Oracle containers

@kasium
Copy link
Copy Markdown
Contributor Author

kasium commented Jun 24, 2021

thanks :-)

@sqla-tester
Copy link
Copy Markdown
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2893 has been merged. Congratulations! :)

@kasium kasium deleted the issue-867 branch June 28, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants