7720: Mysql SET column type values are missing when using the repr method#7772
Closed
nishinishidayo wants to merge 1 commit into
Closed
7720: Mysql SET column type values are missing when using the repr method#7772nishinishidayo wants to merge 1 commit into
nishinishidayo wants to merge 1 commit into
Conversation
nishinishidayo
changed the title
sqla-tester
reviewed
Feb 26, 2022
Collaborator
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision d588454 of this pull request into gerrit so we can run tests and reviews and stuff
Collaborator
|
New Gerrit review created for change d588454: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3636 |
Collaborator
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3636 has been merged. Congratulations! :) |
Collaborator
|
mike bayer (zzzeek) wrote: oracle failure is unrelated View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3643 |
Collaborator
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3643 has been merged. Congratulations! :) |
sqlalchemy-bot
pushed a commit
that referenced
this pull request
Mar 4, 2022
Fixed issues in :class:`_mysql.SET` datatype as well as :class:`.Enum` where the ``__repr__()`` method would not render all optional parameters in the string output, impacting the use of these types in Alembic autogenerate. Pull request for MySQL courtesy Yuki Nishimine. Fixes: #7720 Fixes: #7789 Closes: #7772 Pull-request: #7772 Pull-request-sha: d588454 Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com> Change-Id: Idcec23eab4258511d9f32f4e3d78e511ea6021f1 (cherry picked from commit a926dea)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7720
Mysql SET column type values are missing when using the repr method.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!