Merged
Conversation
suyZhong
requested changes
Aug 11, 2025
sqlancer/Dockerfile
Outdated
|
|
||
| RUN git clone https://github.com/sqlancer/sqlancer.git . && \ | ||
| mvn clean package -DskipTests | ||
| git checkout "${SQLANCER_REF}" && \ |
Collaborator
There was a problem hiding this comment.
It's somewhat not quite elegant. Perhaps we can remove the scripts below and use an old version of cockroach for now; meanwhile, we can raise an issue in SQLancer.
Collaborator
Author
There was a problem hiding this comment.
Reverted the commit to the original version.
sqlancer/Dockerfile
Outdated
| @@ -1,15 +1,47 @@ | |||
| # FROM ubuntu:20.04 | |||
Collaborator
There was a problem hiding this comment.
Perhaps we can remove these comments?
Collaborator
Author
There was a problem hiding this comment.
Reverted the commit to the original version.
cockroachdb/config.json
Outdated
| ], | ||
| "username": "root", | ||
| "password": "", | ||
| "oracle": "CERT", |
Collaborator
There was a problem hiding this comment.
I guess we'll use TLP or NoREC as default?
Collaborator
Author
There was a problem hiding this comment.
Changed it to NoREC.
…krachdb" This reverts commit c04c6f1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As CockroachDB removed certain cluster settings (e.g. sql.metrics.statement_details.plan_collection.enabled) that are still referenced in SQLancer,
the newest commit modifies the SQLancer Dockerfile to remove those references, allowing the build to succeed with the latest CockroachDB.