Separate workflow#9
Merged
CelestaLiu merged 6 commits intomainfrom Jul 19, 2025
Merged
Conversation
…and restart new container if old container exists
suyZhong
reviewed
Jul 18, 2025
| "timeout_seconds": 60, | ||
| "oracle": "FUZZER" | ||
| "init_sql": "CREATE DATABASE test;", | ||
| "init_sql_command": "docker exec {container_name} mysql -u{username} -p{password} -e \"{sql}\"" |
Collaborator
There was a problem hiding this comment.
This one sounds like init_database or? Not so clear for the meaning of this command
Collaborator
Author
There was a problem hiding this comment.
I add init_sql for postgres to create default database test. Deleted from mysql./config.json.
|
|
||
|
|
||
| def test_single(dbms, config_path, use_cache=False): | ||
| def build_environment(dbms, config_path, use_cache, custom=False, dockerfile_path=""): |
Collaborator
There was a problem hiding this comment.
I feel that build_environment should mean that we build the images, and prepare configurations etc. We'll only start the container when we start testing.
Collaborator
Author
There was a problem hiding this comment.
Move start_db to test functions, and extract all the build function to build.py, e.g. build_environment(), build_db_image()...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract build process to build_environment():