Skip to content

Missing break in switch-case.#1

Closed
bostrt wants to merge 1 commit intosqlanywhere:masterfrom
bostrt:master
Closed

Missing break in switch-case.#1
bostrt wants to merge 1 commit intosqlanywhere:masterfrom
bostrt:master

Conversation

@bostrt
Copy link

@bostrt bostrt commented Mar 21, 2014

Fixed issue resulting in segfault and sometimes incorrect result set mapping.

To reproduce before you merge...

Incorrect result map:

var sqlanywhere = require('sqlanywhere');
var conn = sqlanywhere.createConnection();
conn.connect({host: 'xxxx', uid: 'xxxx', pwd: 'xxxx'}, function() {
    console.log(conn.exec('select 1 as a, 2 as b, null as c, 1 as d'));
    conn.disconnect();
});
// Prints [ { a: 1, b: 2, c: 1, d: null } ].....Note the null is associated with "d" now.

Segfault

var sqlanywhere = require('sqlanywhere');
var conn = sqlanywhere.createConnection();
conn.connect({host: 'xxxx', uid: 'xxxx', pwd: 'xxxx'}, function() {
    console.log(conn.exec('select 1, null, null'));
    conn.disconnect();
});

I tried running these tests against SQL Anywhere 10.0.1.3960 and 12.0.1.3873.

Fixed issue resulting in segfault and sometimes incorrect result set mapping
@NeWbLt123
Copy link

Nice!

@efarrar
Copy link
Contributor

efarrar commented Jul 16, 2014

Fixed.

@efarrar efarrar closed this Jul 16, 2014
@NeWbLt123
Copy link

Are you going to update the npm module?

@efarrar
Copy link
Contributor

efarrar commented Jul 16, 2014

Yes. First incorporating a fix for #2, and then will update npm module.

@NeWbLt123
Copy link

Awesome, thank you!

@NeWbLt123
Copy link

Any chance you will update the npm module soon please?

@efarrar
Copy link
Contributor

efarrar commented Jul 18, 2014

Done. 1.0.3 has been published including all fixes on npm.

Sorry for the delay. I wanted to do some additional testing to make sure that the fix for #3 did not cause any unexpected behavior.

@NeWbLt123
Copy link

Thanks and keep up the great work ! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants