This fixes multiple major memory leaks#10
Merged
gperrow-SAP merged 1 commit intosqlanywhere:masterfrom Jan 11, 2016
Merged
Conversation
use of v8::Persistent<T>. Reset() was never called on a Persistent variables. Leaks prevented callbacks and result sets from destruction.
|
|
gperrow-SAP
added a commit
that referenced
this pull request
Jan 11, 2016
This fixes multiple major memory leaks
Contributor
|
Thanks for this submission! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All memory leak issues are related to use of v8::Persistent. Reset() was never called on Persistent variables, which caused memory leaks.
Leaks caused callbacks and result sets to retain.