gen: Ignore empty override settings#128
Merged
kyleconroy merged 1 commit intomasterfrom Nov 7, 2019
Merged
Conversation
The previous `goInnerType` assumed that the column name and table would be non-empty. For computed columns, this is not true. Make sure to check if the override setting (PostgresType or Column) is non-empty before applying an override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
goInnerTypeassumed that the column name and table wouldbe non-empty. For computed columns, this is not true. Make sure to check
if the override setting (PostgresType or Column) is non-empty before
applying an override.
I discovered this with a query that was cast a parameter to a boolean. The generated code assigned the parameter a type of
uuid.UUID.