feat(plugin): add configuration to run go package#4161
Open
frankli0324 wants to merge 1 commit intosqlc-dev:mainfrom
Open
feat(plugin): add configuration to run go package#4161frankli0324 wants to merge 1 commit intosqlc-dev:mainfrom
frankli0324 wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
dosubot
bot
added
size:S
dosubot
bot
added
size:M
Author
|
I've being using this for a while and I didn't run into problems. rebased and squashed. any thoughts on this? @kyleconroy |
Author
|
hi @kyleconroy should I or should I not assume that I can use this option later? I'm trying to decide the workflow of my project... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds "go_package" field under "plugin.process" for configurations
I'm trying to write plugin for a specific project, so I think it's reasonable to put plugin code alongside the project, and currently we need to install the plugin into $PATH before running sqlc generate, this simplifies the process.
I suspect the "cmd" field checks for existence for some reason, so I didn't add a "args" field which may be more universal but less maintainable. I'm not sure about that.