Implement rename_enum option (Fix #2129) #4169
Open
+65
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for renaming Go enum values via a new
rename_enumoption in the configuration. The changes update the code generation logic to use custom names for enum values if specified, and ensure that enum value renaming is handled consistently across global and local options.Configuration and code generation enhancements:
RenameEnumfield to theOptionsandGlobalOptionsstructs ininternal/codegen/golang/opts/options.go, allowing users to specify custom names for enum values. [1] [2]internal/config/v_two.jsonto support the newrename_enumconfiguration property.Parsefunction ininternal/codegen/golang/opts/options.goto merge globalRenameEnummappings into local options during parsing.Enum value naming logic improvements:
EnumValueNamefunction ininternal/codegen/golang/enum.goto accept options and use the custom name fromRenameEnumif available, as well as to respect initialisms.internal/codegen/golang/result.goto use the newEnumValueNamelogic, ensuring renamed values are used in generated code.These changes closes #2129.