dolphin: Implement exapansion with reserved words#620
Merged
kyleconroy merged 1 commit intomasterfrom Jul 24, 2020
Merged
Conversation
compiler: rename the Engine struct to Compiler compiler: move methods onto the Compiler struct compiler: Use backticks for reserved words in MySQL codegen: Handle queries with backticks
kyleconroy
commented
Jul 24, 2020
| ) | ||
|
|
||
| const starExpansionReserved = `-- name: StarExpansionReserved :many | ||
| SELECT ` + "`" + `group` + "`" + ` FROM foo |
Collaborator
Author
There was a problem hiding this comment.
It's gross, but it works 100% of the time and doesn't require a call to strings.Replace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler: rename the Engine struct to Compiler
compiler: move methods onto the Compiler struct
compiler: Use backticks for reserved words in MySQL
codegen: Handle queries with backticks