Skip to content

Conversation

@brody4hire
Copy link

Test for android-database-sqlcipher pull request 81.

@developernotes
Copy link
Member

Hi brodyspark,

We use this test suite to verify support from platform version 2.1-4.1 currently, running across different emulators. Due to the pull requests you've made, not all code is applicable across versions (e.g., Cursor.getType(...) was added in API 11). These tests would then cause build failures for lower versions that do not support that. While we appreciate the effort, we are going to hold off on merging the tests for now. Thanks!

@brody4hire
Copy link
Author

For #1 you are right. For this one (#2): I believe the SQLCipher
version of net.sqlcipher.database.SQLiteStatement.executeUpdateDelete()
should also work for API < 11.

@developernotes
Copy link
Member

Hi brodyspark,

Yes, you are correct - I will merge in #2, thanks for pointing this out! :-)

@developernotes developernotes reopened this Jan 3, 2013
developernotes added a commit that referenced this pull request Jan 3, 2013
Test SQLiteStatement.executeUpdateDelete()
@developernotes developernotes merged commit 1c7368e into sqlcipher:master Jan 3, 2013
@brody4hire
Copy link
Author

Yes, you are correct - I will merge in #2, thanks for pointing this out! :-)

Happy to hear,

Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants