psqldef: Fix handling duplicated PostgreSQL OID from extension #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just implemented more accurate extension detection logic.
PostgreSQL's oid is not globally unique, and you need to search both with its own oid and oid of its object class.
I hit into a conflict case between my table oid & extension's function oid.
Past releases of
psqldefafter e57a042 can eventually see this issue after long run with extensions.I just confirmed
go testfinished successfully undercmd/psqldef.I'm sure this patch fits original intension of e57a042, but I have no ideas about:
pg_typemay require handlingpg_enum, too. ButWHERE relname IN ('pg_type', 'pg_enum')will be still ambiguous between their combinations. I took just mitigation at this point.I can test with my production DBs when #1060 quick solution will be landed.