Fix Lexer string regex to support ansi-sql quoting#740
Merged
JakeWharton merged 4 commits intosqldelight:masterfrom Mar 13, 2026
Merged
Fix Lexer string regex to support ansi-sql quoting#740JakeWharton merged 4 commits intosqldelight:masterfrom
JakeWharton merged 4 commits intosqldelight:masterfrom
Conversation
Regex
Regex
Basic test fixture
JakeWharton
approved these changes
Feb 13, 2026
Contributor
Author
|
@dellisd |
Collaborator
|
I can do a release and Renovate will do the rest. I forgot you can't merge your own PRs in here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes sqldelight/sqldelight#3747
The current regex doesn't support this.
e.g
INSERT INTO foo VALUES ('It''s a string');Fixes the
SqlLexeras this is the actual tokenizer used by the parser at build time.sql.bnfis updated for consistency as is used by GrammarKit tooling.Tested integration with SqlDelight
CHANGELOG.md's "Unreleased" section has been updated, if applicable.