Skip to content

Conversation

@danielebriggi
Copy link
Member

  • release or publish trigger doesn't work when the relase is done by another workflow

@danielebriggi danielebriggi self-assigned this Sep 1, 2025
@danielebriggi danielebriggi force-pushed the refactory-python-package-trigger branch 2 times, most recently from d028da7 to f2c8a0b Compare September 2, 2025 07:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the workflow architecture to fix an issue where release and publish triggers don't work when releases are created by other workflows. The main change separates the release job into its own workflow that triggers after the build workflow completes.

  • Extracts release job from main workflow into separate release.yml workflow
  • Updates python package workflow to trigger on release workflow completion instead of GitHub release events
  • Renames main workflow from "Build, Test and Release SQLite AI" to "Build and Test"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/release.yml New workflow containing the release job extracted from main.yml
.github/workflows/python-package.yml Updates trigger from release events to workflow_run completion
.github/workflows/main.yml Removes release job and updates workflow name

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- release or publish trigger doesn't work when the relase is done by another workflow
@danielebriggi danielebriggi force-pushed the refactory-python-package-trigger branch from f2c8a0b to 9981f61 Compare September 2, 2025 07:56
Copy link
Member

@Gioee Gioee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that the job release is not removed

@danielebriggi danielebriggi force-pushed the refactory-python-package-trigger branch from efde84b to e2150c7 Compare September 2, 2025 13:09
@danielebriggi danielebriggi merged commit 0c6e966 into main Sep 2, 2025
17 checks passed
@danielebriggi danielebriggi deleted the refactory-python-package-trigger branch September 2, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants