Skip to content

Indicate when display strings are being truncated #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2016
Merged

Indicate when display strings are being truncated #767

merged 1 commit into from
Sep 9, 2016

Conversation

justinclift
Copy link
Member

Also reduce the minimum length to 1, just in case it's useful for
people.

For #761.

@justinclift
Indicate when display strings are being truncated
0c7605b 
Also reduce the minimum length to 1, just in case it's useful for
people
@justinclift justinclift added the enhancement Feature requests. label Sep 8, 2016
@justinclift
Copy link
Member Author

Making this a PR instead of just committing it in case there's a better way. 😄

@justinclift
Copy link
Member Author

Note, I'm not sure if the "..." should be wrapped by tr() or not.

@chrisjlocke
Copy link
Member

Does tr() simply translate it? Wouldn't that cause unnecessary delay?

@justinclift
Copy link
Member Author

With tr(), it allows the enclosed text to be translated (eg using Qt Linguist). At runtime it shows the translated version of the text (instead of English) if one is available. 😄

The delay from looking up a translated version of " ..." would be measured in (very low) microseconds. Unless using a 286 or something. 😉

@justinclift justinclift merged commit 7deeb02 into sqlitebrowser:master Sep 9, 2016
@justinclift justinclift deleted the display_truncated_length_symbol branch September 9, 2016 09:22
@justinclift
Copy link
Member Author

Merged it. The code is pretty simple, and seems to work without side effects.

@justinclift justinclift self-assigned this Sep 9, 2016
justinclift added a commit that referenced this pull request Oct 1, 2016
@justinclift
Indicate when display strings are being truncated
a085d9d 
For #767

(manually cherry picked from commit 0c7605b
by Justin Clift)
vtronko pushed a commit that referenced this pull request Dec 29, 2016
@justinclift
Merge pull request #767 from justinclift/display_truncated_length_symbol
e2ae1ad 
Indicate when display strings are being truncated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinclift justinclift

Labels

enhancement Feature requests.

Projects

None yet

Milestone

3.9.1 - A bit of polish shouldn't hur...

Development

Successfully merging this pull request may close these issues.

2 participants

@justinclift @chrisjlocke