Adds ability to escape identifiers w/ tests#216
Merged
ahmad-moussawi merged 3 commits intosqlkata:masterfrom Mar 20, 2019
Merged
Adds ability to escape identifiers w/ tests#216ahmad-moussawi merged 3 commits intosqlkata:masterfrom
ahmad-moussawi merged 3 commits intosqlkata:masterfrom
Conversation
Contributor
ahmad-moussawi
left a comment
ahmad-moussawi
left a comment
There was a problem hiding this comment.
Nice PR!, why checking for the opening bracket ( in the regex?
Contributor
Author
|
It's not looking for the paren, it's just part of the matching group. "Zero-width negative lookbehind. Look behind the current position to determine whether subexpression does not match the input string." I'd also like to apply the escape behavior to the Compiler.WrapValue() method, but I'm trying to determine a clean way of accomplishing that -- any ideas? |
…g both escaped and non-escaped identifiers
Contributor
Author
|
I added some more tests and tweaked the regex, I feel like this is now complete. |
Contributor
|
Merged with the master branch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a commit to allow for escaping identifiers #215