Update Compiler.cs #251
Open
Update Compiler.cs #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrderBy's and Limit's are should be after UNION
Contributor
|
Could you please add unit test for this ? |
Author
|
I don't know how to connect visual studio to github. I just types the change in a textearea inside github website. The change has been tested inside a project of mine, by inheriting sqlitecompiler and overriding the function. |
ahmad-moussawi
force-pushed
the
master
branch
6 times, most recently
from
f9a6417 to
a30bb49
Compare
ahmad-moussawi
force-pushed
the
master
branch
7 times, most recently
from
838f8ca to
47633a3
Compare
ahmad-moussawi
force-pushed
the
master
branch
2 times, most recently
from
748c2bf to
bad6733
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the order of SQL query compilation by moving UNION clauses before ORDER BY and LIMIT clauses to comply with standard SQL syntax requirements.
- Reorders the compilation sequence to place UNION before ORDER BY and LIMIT
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderBy's and Limit's are should be after UNION