Allowing for Key and Column attributes, and continue on key. #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2019 08:34
…, then key, then prop name. Needed Package Ref to Microsoft Test SDK for the tests to run (in JetBrains Rider at least).
added 2 commits
June 6, 2019 10:07
ahmad-moussawi
force-pushed
the
master
branch
6 times, most recently
from
f9a6417 to
a30bb49
Compare
ahmad-moussawi
force-pushed
the
master
branch
7 times, most recently
from
838f8ca to
47633a3
Compare
ahmad-moussawi
force-pushed
the
master
branch
2 times, most recently
from
748c2bf to
bad6733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheDictionaryProperties wasn't being used.... should it?
There was an error if the Key attribute and Column attribute were both on a property. Since Key inherits from Column
var colAttr = property.GetCustomAttribute(typeof(ColumnAttribute)) as ColumnAttribute;threw an exception.Another error, when the Key attribute was present the column and value were added to the Where clause, but then also added to the Set clause. This throws an exception from the db (at least on SQL Server). Adding a
continue;to skip the Set clause for the Key.