Skip to content

Avoid parameter sniffing for exists subquery #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmad-moussawi merged 3 commits into from
Oct 22, 2019
Merged

Avoid parameter sniffing for exists subquery #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dd6839
Avoid parameter sniffing for exists subquery
yoosoopov Oct 22, 2019
4d76906
Avoid parameter sniffing for exists subquery, fix tests
yoosoopov Oct 22, 2019
de08573
Avoid parameter sniffing for exists subquery, fix tests
yoosoopov Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion QueryBuilder.Tests/DefineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ public void Test_Define_WhereExists()
);

var c = Compile(query);
Assert.Equal("SELECT * FROM [Customers] WHERE EXISTS (SELECT TOP (1) 1 FROM [Orders] WHERE [ShipPostalCode] = '8200')", c[EngineCodes.SqlServer]);
Assert.Equal("SELECT * FROM [Customers] WHERE EXISTS (SELECT 1 FROM [Orders] WHERE [ShipPostalCode] = '8200')", c[EngineCodes.SqlServer]);
}


Expand Down
2 changes: 1 addition & 1 deletion QueryBuilder.Tests/SqlServer/NestedSelectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void SqlCompile_QueryLimitAndNestedLimit_BindingValue()
// var q = new Query().From("Foo").Where("C", "c").WhereExists(n).Where("A", "a");

var actual = compiler.Compile(q).ToString();
Assert.Contains("SELECT * FROM [Foo] WHERE [x] = true AND NOT EXISTS (SELECT TOP (1) 1 FROM [Bar])",
Assert.Contains("SELECT * FROM [Foo] WHERE [x] = true AND NOT EXISTS (SELECT 1 FROM [Bar])",
actual);
// Assert.Contains("SELECT * FROM [Foo] WHERE [C] = 'c' AND EXISTS (SELECT TOP (1) 1 FROM [Bar]) AND [A] = 'a'", actual);
}
Expand Down
5 changes: 2 additions & 3 deletions QueryBuilder/Base.Where.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,8 +527,7 @@ public Q WhereExists(Query query)

// remove unneeded components
query = query.Clone().ClearComponent("select")
.SelectRaw("1")
.Limit(1);
.SelectRaw("1");

return AddComponent("where", new ExistsCondition
{
Expand Down Expand Up @@ -690,4 +689,4 @@ public Q OrWhereNotTime(string column, object value)
#endregion

}
}
}