-
Notifications
You must be signed in to change notification settings - Fork 27
Issue #3: Use relative imports #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why didn't you pick up from #8? |
|
Also more than half of your commit messages are the same text. |
|
I didn't pick up from #8 since trunk has diverged suffiiently far (pydispatcher dropped, various other changes) that it didn't seem worth the effort of sorting out the required updates to that branch. |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replaces a number of imports with relative imports, as discussed in issue #3 .
I haven't looked at fixing imports in the test suite yet, so this is not a complete fix.
The commits from 8fc60f4 onwards are minimal workarounds to get py.test to collect the tests on python 3.4, and should not be considered the final solution.