add empty_option to the form component
#694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add empty option to select
Collaborator
|
Thank you ! You also need to document the new option, otherwise no one will know about it. The documentation for the form component is here: https://github.com/sqlpage/SQLPage/blob/main/examples/official-site/sqlpage/migrations/01_documentation.sql#L232-L273 |
Collaborator
|
Ideally, you would also update the select example below, to demonstrate the usage of the new option. |
Add documentation
Contributor
Author
|
Like that, it's good ? |
lovasoa
requested changes
Nov 16, 2024
Collaborator
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
I suggest we name it empty_option to follow the snake_case wording of other sqlpage component properties.
lovasoa
changed the title
empty_option to the form component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add empty option to select