Swipe Action Updates #489
Merged
Swipe Action Updates #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
commented
May 19, 2023
kyleve
commented
May 19, 2023
kyleve
changed the title
nononoah
approved these changes
May 31, 2023
Comment on lines
+287
to
+295
| guard let swipeActions = self.model.leadingSwipeActions else { | ||
| assertionFailure("Cannot showLeadingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | ||
| return | ||
| } | ||
|
|
||
| guard swipeActions.actions.isEmpty == false else { | ||
| assertionFailure("Cannot showLeadingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
🐴
Suggested change
| guard let swipeActions = self.model.leadingSwipeActions else { | |
| assertionFailure("Cannot showLeadingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | |
| return | |
| } | |
| guard swipeActions.actions.isEmpty == false else { | |
| assertionFailure("Cannot showLeadingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | |
| return | |
| } | |
| guard self.model.leadingSwipeActions?.isEmpty == false else { | |
| assertionFailure("Cannot showLeadingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | |
| return | |
| } |
Collaborator
Author
There was a problem hiding this comment.
I started with this, but explicitly split it into two asserts, so when hitting the breakpoint, you'd understand if there was a swipe actions config vs if the swipe actions array was empty.
Comment on lines
+302
to
+310
| guard let swipeActions = self.model.trailingSwipeActions else { | ||
| assertionFailure("Cannot showTrailingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | ||
| return | ||
| } | ||
|
|
||
| guard swipeActions.actions.isEmpty == false else { | ||
| assertionFailure("Cannot showTrailingSwipeActions for `\(self.model.identifier)`, as no swipe actions have been provided.") | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
Same hobbyhorse here to take or leave.
| /// Pass in `true` to expand the actions (typically only used when deleting the row) | ||
| /// or `false` to collapse them. | ||
| public typealias CompletionHandler = (_ expandActions: Bool) -> Void | ||
| public typealias OnDidPerformAction = (OnDidPerformActionAnimation) -> Void |
Collaborator
There was a problem hiding this comment.
Minor, but nice updates!
* origin/main: Prep 11.0 release Paged list layouts now support using bounds, instead of itemInsets. Prep 10.3.1 release Update CHANGELOG iOS 17.0b1 first responder changes
Collaborator
Author
|
Note, build is failing due to something around xrOS: XcodesOrg/XcodesApp#401 |
kyleve
added a commit
that referenced
this pull request
Jul 10, 2023
* origin/main: Swipe Action Updates (#489)
Merged
kyleve
added a commit
that referenced
this pull request
Nov 19, 2023
…rovements * origin/main: (123 commits) Update CHANGELOG.md (#508) Revert "Supplementary Tracking Fixes (#433)" Revert "Force layout before appear, to avoid animated updates (#505)" Force layout before appear, to avoid animated updates (#505) Update workaround versions (#506) Fix supplementary view + contained first responder reuse issue (#507) Supplementary Tracking Fixes (#433) Release 13.0.0 (#504) Update KeyboardObserver (#499) CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged Release 12.0.0 (#501) CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500) CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app. expose onKeyboardFrameWillChange on ListProperties onKeyboardFrameWillChange: Improve CHANGELOG, DocC CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior remove contentOffset from isContentScrollable calculation, improve comment Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494) Swipe Action Updates (#489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes I need for the delete button work in Market:
Apply*Infoto theBlueprintEnvironment: This allows us to magically wire up tapping the remove button exposes the swipe actions in the Market implementation: https://github.com/squareup/market/pull/6261SwipeActionproperty andtypealiasnames to align better with what each actually does.true/falseflag passed to the swipe action completion with an enum, so it's clear from the callsite what the argument is actually for.Checklist
Please do the following before merging:
Mainsection.