Adding a completion handler to the scrollToSection API.
#585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnewman-square
force-pushed
the
johnnewman/feature/section-scroll-completion
branch
from
0e8a438 to
0fe806b
Compare
johnnewman-square
force-pushed
the
johnnewman/feature/section-scroll-completion
branch
3 times, most recently
from
3cea6ac to
10613e8
Compare
johnnewman-square
force-pushed
the
johnnewman/feature/section-scroll-completion
branch
from
10613e8 to
2c2469a
Compare
g-mark
approved these changes
Jul 2, 2025
| scrollExpectation.fulfill() | ||
| } | ||
| ) | ||
| wait(for: [scrollExpectation], timeout: 0.5) |
Contributor
There was a problem hiding this comment.
This is fine as is, but I wonder if we could either disable animations on the view (if it doesn't interfere with the scrolling behavior) or use something like window.layer.speed = 4 to speed up the testing?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I've set the window speed to 4 for these tests. That may reduce the test duration a bit in CI. (UIView.setAnimationsEnabled(false) causes unit tests to break, so I'll stick with the window speed for now.)
johnnewman-square
deleted the
johnnewman/feature/section-scroll-completion
branch
kyleve
added a commit
that referenced
this pull request
Jul 24, 2025
…-headerfooters * origin/main: build: set up tuist (#584) Bumping versions to 16.3.0 (#589) Reset scroll position if list identifier changes (#588) Bumping versions to 16.2.0 (#587) Adding a completion handler to the `scrollToSection` API. (#585) Adding a programmatic scroll completion handler (#582) Remove iOS 19 (26) cap of the collection view first responder workaround (#581) Bumping versions to 16.1.0 (#583) Update for Blueprint 6.0.0 (#580) Bumping versions to 16.0.4. (#579) Update the first responder resignation workaround to be enabled by default and cap at < iOS 19 [UI-8849] (#578) Bumping versions to 16.0.3 (#577) Bottom gravity and autoscroll improvements (#576) Bumping versions to 16.0.2 (#574) Addressing an AutoScrollAction issue when using VerticalLayoutGravity.bottom (#572) release: Prepare 16.0.1 release (#569) Fix reordering crash introduced in 16.0 (#568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the changes in #582, adding a completion handler to the
scrollToSection(...)API. This also adds a demo to showcase this API with various configurations:Checklist
Please do the following before merging:
Mainsection.