Merged
Conversation
|
Stephane Nicolas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
Author
|
It passed and I don't see the error anymore. |
909a346 to
f9d6c8f
Compare
vRallev
reviewed
Jul 16, 2020
| import org.gradle.api.services.BuildServiceParameters.None | ||
|
|
||
| /** This signal is used to share state between the task above and Kotlin compile tasks. */ | ||
| open abstract class IncrementalSignal : BuildService<None> { |
Collaborator
There was a problem hiding this comment.
An abstract class is automatically open. open is redundant.
vRallev
reviewed
Jul 16, 2020
| ) | ||
| // We avoid a reference to the project in the doFirst. | ||
| val projectPath = project.path | ||
| val incremental = incrementalSignal.get().incremental[projectPath] |
Collaborator
There was a problem hiding this comment.
You call this too early. It has to happen in the doFirst, because otherwise the task that toggles this flag didn't run, yet.
vRallev
reviewed
Jul 16, 2020
| compileTask.doFirst { | ||
| // If the signal is set, then the plugin classpath changed. Apply the setting that | ||
| // DisableIncrementalCompilationTask requested. | ||
|
|
Collaborator
There was a problem hiding this comment.
Move this empty line above the comment.
f9d6c8f to
ba7caac
Compare
ba7caac to
5fc83d1
Compare
vRallev
approved these changes
Jul 16, 2020
Collaborator
|
Tested and confirmed locally that incremental builds still work as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using versions: [Kotlin:1.4-M3, Gradle:6.5, AGP 4.1 beta 04], I could detect some issues when running instant execution:
This PR fixes the various issues. Thx to @bamboo for the guidance