This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Fix utf-8 handling.#46
Merged
alokmenghrajani merged 1 commit intomasterfrom Sep 16, 2016
Merged
Conversation
Closed
Jose spec mentions that the plaintext should be encoded as utf-8 bytes. Javascript by default uses utf-16, so we need to convert when encrypting/decrypting/signing. This commit is based on the work by rapropos (see #42). I prefer to minimize the code size by re-using existing string manipulation functions.
alokmenghrajani
force-pushed
the
alok/unicode
branch
from
d38dd43 to
bc412b9
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jose spec mentions that the plaintext should be encoded as utf-8 bytes. Javascript by
default uses utf-16, so we need to convert when encrypting/decrypting/signing.
This commit is based on the work by rapropos (see #42).
I prefer to minimize the code size by re-using existing string manipulation functions.