This repository was archived by the owner on Feb 27, 2023. It is now read-only.
[Zhen] fix the babel-loader config.#91
Merged
alokmenghrajani merged 2 commits intosquare:masterfrom Apr 12, 2019
Merged
Conversation
|
|
webpack.prod.js
Outdated
| }, | ||
|
|
||
| test: /\.js$/ | ||
| test: /\.m?js$/ |
Contributor
Author
There was a problem hiding this comment.
This config is copied from webpack babel-loader document. .mjs is the es module js file extension.
For this project, don't need it. I can update it to ".js"
Contributor
|
LGTM. I can merge once the CLA is signed. |
…s files, doesn't need the mjs.
Contributor
Author
Done. |
alokmenghrajani
approved these changes
Apr 12, 2019
Contributor
|
Thanks. Do you need a npm release or are you ok with just the fix in master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dist file doesn't convert by babel env preset(e.g. dist js file contain the arrow function, which can't work for ie 11), fix it.