Crash in `RootViewWatcher$listener$1.onRootViewAdded`

[sankiran-s]

Description

This exception causes our app to crash at runtime.
Also, it seems to happen mostly in views that host a webview.

       at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:261)
       at android.content.res.Resources.getBoolean(Resources.java:1251)
       at leakcanary.RootViewWatcher$listener$1.onRootViewAdded(RootViewWatcher.kt:53)
       at curtains.OnRootViewAddedListener$DefaultImpls.onRootViewsChanged(OnRootViewAddedListener.java:38)
       at leakcanary.RootViewWatcher$listener$1.onRootViewsChanged(RootViewWatcher.kt:43)
       at curtains.internal.RootViewsSpy$delegatingViewList$1.add(RootViewsSpy.kt:25)
       at curtains.internal.RootViewsSpy$delegatingViewList$1.add(RootViewsSpy.kt:23)
       at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:554)
       at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:150)
       at android.app.Dialog.show(Dialog.java:512)
       at WV.hM.a(chromium-TrichromeWebViewGoogle6432.aab-dev-662800033:3)
       at org.chromium.content.browser.input.SelectPopup.show(chromium-TrichromeWebViewGoogle6432.aab-dev-662800033:174)
       at android.os.MessageQueue.nativePollOnce(MessageQueue.java)
       at android.os.MessageQueue.next(MessageQueue.java:335)
       at android.os.Looper.loopOnce(Looper.java:187)
       at android.os.Looper.loop(Looper.java:319)
       at android.app.ActivityThread.main(ActivityThread.java:8918)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Upon analyzing the APK, I found that the resource is indeed present inside the APK.

Also, the R8 resource mapping maps to the correct resource ID as well.
bool:leak_canary_watcher_watch_dismissed_dialogs:2131034121 (0x7f050009 in hexadecimal)

Steps to Reproduce

We haven't been able to reproduce the issue on our end, but we're seeing several users affected across OEMs, and Android versions.

Expected behavior: App should not crash

Version Information

• LeakCanary version: 2.14
• Android OS version: Android 10 through Android 14
• Gradle version: 8.8

Additional Information

Android Gradle Plugin version: 8.5.0

[CracklyBody]

I also got the same error. And found how to reproduce it. It happens on google pixel 7 with android 14+.
Add webview in your android app, then find a web page that can open a dialog, when you tries to open the dialog it will crash because of resource could not be found

[CracklyBody]

There is no bug in version 3.0-alpha-1 ...... 3.0-alpha-8 only in <2.14

Environment

• LeakCanary Version: 2.14
• Android Studio: Koala 2024.1.1
• Device/Emulator: real Pixel 7 android 14

Reproduction Steps

I've identified a consistent way to reproduce this issue with WebView dialogs and LeakCanary:

1. Create a New Android Project

Create a basic Android application project in Android Studio.

2. Add LeakCanary Dependency

Add LeakCanary to the project by including the following in your module's build.gradle file:

dependencies {
    // Other dependencies...
    debugImplementation("com.squareup.leakcanary:leakcanary-android:2.14")
}

3. Create Layout with WebView

Set up a basic activity layout with a WebView:

<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".MainActivity">
    
    <WebView
        android:id="@+id/webView"
        android:layout_width="0dp"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent" />
        
</androidx.constraintlayout.widget.ConstraintLayout>

4. Implement MainActivity

Create a MainActivity that loads HTML content with form elements that trigger system dialogs:

class MainActivity : AppCompatActivity() {
    private lateinit var binding: ActivityMainBinding
    
    @SuppressLint("SetJavaScriptEnabled")
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        binding = ActivityMainBinding.inflate(layoutInflater)
        setContentView(binding.root)
        
        // Enable JavaScript
        binding.webView.settings.javaScriptEnabled = true
        
        // Set WebViewClient to handle page navigation within the WebView
        binding.webView.webViewClient = WebViewClient()
        
        // Set WebChromeClient to handle JavaScript dialogs, favicons, etc.
        binding.webView.webChromeClient = WebChromeClient()
        
        // Load the test HTML page with select dialog trigger
        binding.webView.loadDataWithBaseURL(
            null,
            getHtmlContent(),
            "text/html",
            "UTF-8",
            null
        )
    }
    
    private fun getHtmlContent(): String {
        return """
            <!DOCTYPE html>
            <html>
            <head>
                <meta name="viewport" content="width=device-width, initial-scale=1.0">
                <title>LeakCanary Test</title>
                <style>
                    body {
                        font-family: Arial, sans-serif;
                        padding: 20px;
                    }
                    button, select {
                        padding: 10px;
                        margin: 10px 0;
                        font-size: 16px;
                    }
                </style>
            </head>
            <body>
                <h2>WebView Dialog Test</h2>
                
                <p>Tap the select element below to trigger a system dialog:</p>
                
                <select id="dropdownMenu">
                    <option value="option1">Option 1</option>
                    <option value="option2">Option 2</option>
                    <option value="option3">Option 3</option>
                    <option value="option4">Option 4</option>
                    <option value="option5">Option 5</option>
                </select>
                
                <p>Or click the button to show a date picker:</p>
                
                <input type="date" id="datePicker">
                
                <p>Try both before and after app restart to test the LeakCanary issue.</p>
            </body>
            </html>
        """.trimIndent()
    }
    
    override fun onBackPressed() {
        if (binding.webView.canGoBack()) {
            binding.webView.goBack()
        } else {
            super.onBackPressed()
        }
    }
}

5. Reproduce the Issue

1. Build and run the app on a device or emulator
2. Tap both the dropdown selector and date picker (they should work fine on first run)
3. Close the app completely
4. Restart the app
5. Tap either the dropdown selector or date picker again

6. Observe the Crash

After the app restart, tapping on either form element will trigger a crash with the following error:

android.content.res.Resources$NotFoundException: Resource ID #0x7f050013
    at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:xxx)
    at android.content.res.Resources.getBoolean(Resources.java:xxx)
    at leakcanary.RootViewWatcher$listener$1.onRootViewAdded(RootViewWatcher.kt:53)

Key Observations

• The crash only occurs after app restart, not on first install
• It's specifically triggered when a WebView opens a system dialog (like SelectPopup or DatePicker)
• LeakCanary is trying to access its own resources but fails to find them after restart
• This appears to be related to how LeakCanary's RootViewWatcher monitors new root views

I hope this detailed reproduction helps in identifying and fixing the issue. Let me know if you need any additional information.

[arekolek]

Looks like it was fixed long before 2.14 was released, but the fix landed only in 3.x https://github.com/square/leakcanary/pull/2612/files#diff-1bf7116f83d9f433b4f62be78e84e83842d21d3dba666297a8ecb0bdf844b09a

[andreas-sanjaya4]

Adding some information :
I have tried with multiple combination webview and it's crashed since webview 134 onwards.

[TWiStErRob]

@pyricau is there a planned 2.x maintenance release? or should we be using 3.x alphas?