EBDAF Exception

[pguilbot]

I use OkHTTP for my android app.

I get a lot of crashes related to an Http issue :
java.lang.AssertionError: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)

Coming from :
at com.squareup.okhttp.internal.http.SocketConnector.connectTls(SocketConnector.java:103)
or
at com.squareup.okhttp.internal.Util.closeQuietly(Util.java:105)
or
at com.squareup.okhttp.internal.Platform$Android.connectSocket(Platform.java:190)

Is there a solution to catch this exception ?

Thanks

[swankjesse]

@nfuller any ideas?

[iNoles]

Could be https://code.google.com/p/android/issues/detail?id=54072 ?

[nfuller]

@pguilbot Going to need more information. What version of Android is affected? I've found similar examples from ~2012 (against ICS). Are you doing things from multiple threads?

Can you send the full stack traces, too? Feel free to obfuscate your own app's parts of the stack.

The one @iNoles also looks like a possibility. Hard to tell without more info, though.

There's also https://code.google.com/p/android/issues/detail?id=81700, which apparently I own. OkHttp doesn't use nio, though, from what I can see so unless it has a common cause it's probably not that.

[swankjesse]

@pguilbot if you could provide a URL that reproduces this, or a test case, or anything we can make forward progress & I'll reopen this issue. For now we're stalled on insufficient information.

[pguilbot]

Hi all,
Thanks for your fast reply.

I think that the @iNoles issue is definitely a possibility.

Here are some full stack traces causing this issue :

---

java.lang.AssertionError: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:649)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:162)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:928)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:425)
at com.squareup.okhttp.internal.http.SocketConnector.connectTls(SocketConnector.java:103)
at com.squareup.okhttp.Connection.connect(Connection.java:143)
at com.squareup.okhttp.Connection.connectAndSetOwner(Connection.java:185)
at com.squareup.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:128)
at com.squareup.okhttp.internal.http.HttpEngine.nextConnection(HttpEngine.java:341)
at com.squareup.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:330)
at com.squareup.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:248)
at com.squareup.okhttp.Call.getResponse(Call.java:273)
at com.squareup.okhttp.Call$ApplicationInterceptorChain.proceed(Call.java:230)
at com.squareup.okhttp.Call.getResponseWithInterceptorChain(Call.java:201)
at com.squareup.okhttp.Call.access$100(Call.java:36)
at com.squareup.okhttp.Call$AsyncCall.execute(Call.java:164)
at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
at java.lang.Thread.run(Thread.java:838)
Caused by: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.Posix.getsockname(Posix.java)
at libcore.io.ForwardingOs.getsockname(ForwardingOs.java:69)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:645)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:162)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:928)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:425)
at com.squareup.okhttp.internal.http.SocketConnector.connectTls(SocketConnector.java:103)
at com.squareup.okhttp.Connection.connect(Connection.java:143)
at com.squareup.okhttp.Connection.connectAndSetOwner(Connection.java:185)
at com.squareup.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:128)
at com.squareup.okhttp.internal.http.HttpEngine.nextConnection(HttpEngine.java:341)
at com.squareup.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:330)
at com.squareup.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:248)
at com.squareup.okhttp.Call.getResponse(Call.java:273)
at com.squareup.okhttp.Call$ApplicationInterceptorChain.proceed(Call.java:230)
at com.squareup.okhttp.Call.getResponseWithInterceptorChain(Call.java:201)
at com.squareup.okhttp.Call.access$100(Call.java:36)
at com.squareup.okhttp.Call$AsyncCall.execute(Call.java:164)
at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
at java.lang.Thread.run(Thread.java:838)

---

java.lang.AssertionError: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:641)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:162)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:895)
at com.squareup.okhttp.internal.Util.closeQuietly(Util.java:105)
at com.squareup.okhttp.ConnectionPool.performCleanup(ConnectionPool.java:315)
at com.squareup.okhttp.ConnectionPool.runCleanupUntilPoolIsEmpty(ConnectionPool.java:242)
at com.squareup.okhttp.ConnectionPool.access$000(ConnectionPool.java:54)
at com.squareup.okhttp.ConnectionPool$1.run(ConnectionPool.java:97)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:838)
Caused by: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.Posix.getsockname(Posix.java)
at libcore.io.ForwardingOs.getsockname(ForwardingOs.java:65)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:637)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:162)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:895)
at com.squareup.okhttp.internal.Util.closeQuietly(Util.java:105)
at com.squareup.okhttp.ConnectionPool.performCleanup(ConnectionPool.java:315)
at com.squareup.okhttp.ConnectionPool.runCleanupUntilPoolIsEmpty(ConnectionPool.java:242)
at com.squareup.okhttp.ConnectionPool.access$000(ConnectionPool.java:54)
at com.squareup.okhttp.ConnectionPool$1.run(ConnectionPool.java:97)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:838)

---

java.lang.AssertionError: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:640)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:173)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:895)
at okio.Okio$3.timedOut(Okio.java:206)
at okio.AsyncTimeout$Watchdog.run(AsyncTimeout.java:278)
Caused by: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
at libcore.io.Posix.getsockname(Posix.java)
at libcore.io.ForwardingOs.getsockname(ForwardingOs.java:65)
at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:636)
at libcore.io.IoBridge.closeSocket(IoBridge.java:202)
at java.net.PlainSocketImpl.close(PlainSocketImpl.java:173)
at java.net.Socket.close(Socket.java:319)
at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:895)
at okio.Okio$3.timedOut(Okio.java:206)
at okio.AsyncTimeout$Watchdog.run(AsyncTimeout.java:278)

---

This issue is coming from android 4 (up to 4.2.2). -> 99,9%
I get at least one crash from android 5.0.1

I use OkHttp client to do some Https request to a personal API.
For the moment I am unable to reproduce this issue.

[pguilbot]

Hi all,
I just want to follow up with this issue.
@nfuller / @swankjesse : Any ideas regarding my full stack traces ?
Thanks

[nfuller]

@pguilbot

Nothing I can really say. I just looked and the line numbers don't appear to correspond with code in AOSP (at least, not code from the master branch) so I can't be sure what is running on device. I vaguely recall going round this loop before: OEM's can add their own code which makes it difficult to pin down.

Looks like one may have done so: In the Android repos, I can't find any version of the code that calls getSocketLocalPort() from within closeSocket() but it's possible this is what we'd see if somebody called getSocketLocalPort() on an already closed socket....?

Assuming this is a bug in the device, the options open to you:

1. The Socket code / SSL socket implementation are on the device. You might look at the Google Play Services dynamic security provider API calls. That would swap in a more modern SSLSocketFactory and may bypass the issue. Unclear whether it actually would. It should, but may have other side effects.

2. Change Okio to handle the assertion error in addition to the SocketException for this legacy case. Right now, if the SocketException is still being thrown, it is being swallowed in Okio.timedOut().

I suspect the 5.0.1 crash is something else. If you can catch that one you might have found a more current bug.

[imort]

Hello @swankjesse,
Sadly, we are still experiencing this issue with okhttp 2.5.0

Caused by: java.lang.AssertionError: libcore.io.ErrnoException: getsockname failed: EBADF (Bad file number)
            at libcore.io.IoBridge.getSocketLocalPort(IoBridge.java:603)
            at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:155)
            at java.net.Socket.connect(Socket.java:868)
            at com.squareup.okhttp.internal.Platform$Android.connectSocket(Platform.java:190)
            at com.squareup.okhttp.Connection.connectSocket(Connection.java:196)
            at com.squareup.okhttp.Connection.connect(Connection.java:172)
            at com.squareup.okhttp.Connection.connectAndSetOwner(Connection.java:367)
            at com.squareup.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:128)
            at com.squareup.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:328)
            at com.squareup.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:245)
            at com.squareup.okhttp.Call.getResponse(Call.java:267)
            at com.squareup.okhttp.Call$ApplicationInterceptorChain.proceed(Call.java:224)
            at com.squareup.okhttp.Call.getResponseWithInterceptorChain(Call.java:195)
            at com.squareup.okhttp.Call.execute(Call.java:79)

Seems like catching such exception in Connection.connectTls() is not enough and Platform.get().connectSocket(socket, route.getSocketAddress(), connectTimeout);
needs it too.

[swankjesse]

https://github.com/square/okhttp/pull/1896/files

[imort]

Looks good to me, cant't wait for the update
Thank you