Always pass a host to NetworkSecurityPolicy.isCleartextTrafficPermitted #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed(). Previously we were misinterpretting which hosts this method applied to. Suppose an Android app was configured to require TLS for bank.com and not for any other address. The NetworkSecurityPolicy.isCleartextTrafficPermitted() method would return false because cleartext traffic wasn't universally permitted. And OkHttp would incorrectly forbid cleartext communication to other hosts like puppies.com. Closes: #2640
swankjesse
force-pushed
the
jwilson.0702.cleartext
branch
from
aa1bc03 to
1f58b14
Compare
Collaborator
|
Lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were misinterpretting which hosts this method applied to.
Suppose an Android app was configured to require TLS for bank.com and
not for any other address. The NetworkSecurityPolicy.isCleartextTrafficPermitted()
method would return false because cleartext traffic wasn't universally
permitted. And OkHttp would incorrectly forbid cleartext communication
to other hosts like puppies.com.
Closes: #2640