Merged
Conversation
JakeWharton
commented
Oct 12, 2016
| private final String name; | ||
|
|
||
| /** The thread looping the reader. Will become null when looping stops for any reason. */ | ||
| private volatile Thread looperThread; |
Collaborator
Author
There was a problem hiding this comment.
This is so named because fields prefixed with 'reader' are documented as only being accessible on the reader thread.
JakeWharton
force-pushed
the
jw/forbid-writes-on-reader
branch
from
0cc7566 to
8ab575e
Compare
JakeWharton
commented
Oct 12, 2016
|
|
||
| /** Send an unsolicited pong with the specified payload. */ | ||
| final void sendPong(ByteString payload) throws IOException { | ||
| public final void pong(ByteString payload) throws IOException { |
Collaborator
Author
There was a problem hiding this comment.
Note: not actually a public API since this is internal
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2902.