Skip to content

Support PATCH requests in MockWebServer#368

Merged
JakeWharton merged 1 commit intosquare:masterfrom
nacx:mock-patch
Dec 13, 2013
Merged

Support PATCH requests in MockWebServer#368
JakeWharton merged 1 commit intosquare:masterfrom
nacx:mock-patch

Conversation

@nacx
Copy link
Copy Markdown
Contributor

@nacx nacx commented Dec 13, 2013

The HttpURLConnectionImpl supports PATCH methods with a body. MockWebServer shouldn't reject those requests.

@JakeWharton
Copy link
Copy Markdown
Collaborator

Thanks! Can you sign our CLA so that we can redistribute your code?

@nacx
Copy link
Copy Markdown
Contributor Author

nacx commented Dec 13, 2013

Done!

@JakeWharton
Copy link
Copy Markdown
Collaborator

LGTM. Just waiting on Travis CI now...

@JakeWharton
Copy link
Copy Markdown
Collaborator

Builds and passes locally. Travis is still a big flaky sometimes.

JakeWharton added a commit that referenced this pull request Dec 13, 2013
Support PATCH requests in MockWebServer
@JakeWharton JakeWharton merged commit 29f48ef into square:master Dec 13, 2013
@nacx nacx deleted the mock-patch branch December 13, 2013 17:15
@nacx
Copy link
Copy Markdown
Contributor Author

nacx commented Dec 13, 2013

Thanks @JakeWharton !

@codefromthecrypt
Copy link
Copy Markdown

Awesome response time @JakeWharton!

@codefromthecrypt
Copy link
Copy Markdown

Thanks for the code @nacx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants