Explain prior responses issue for App Interceptors #5752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
For discussion, tests to come. |
| return // Already ready. | ||
| } | ||
| check(exchange == null) | ||
| check(exchange == null) { "Transmitted has existing exchange, has an app interceptor left prior responses open?" } |
There was a problem hiding this comment.
Suggested change
| check(exchange == null) { "Transmitted has existing exchange, has an app interceptor left prior responses open?" } | |
| check(exchange == null) { "Transmitter has existing exchange, has an app interceptor left prior responses open?" } |
I assume this is what was intended.
swankjesse
approved these changes
Jan 25, 2020
| return // Already ready. | ||
| } | ||
| check(exchange == null) | ||
| check(exchange == null) { "Transmitter has existing exchange, has an app interceptor left prior responses open?" } |
Collaborator
There was a problem hiding this comment.
Wanna use the exact same text we use on line 158?
Collaborator
There was a problem hiding this comment.
(possibly fixing that line to match this!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.