Attempt to minimise WebSocket test flakiness#6045
Merged
yschimke merged 9 commits intosquare:masterfrom May 13, 2020
Merged
Conversation
swankjesse
approved these changes
May 13, 2020
|
|
||
| private fun logWithTime(message: String) { | ||
| val timeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNs) | ||
| val timeMs = if (startNs == 0L) { |
Collaborator
There was a problem hiding this comment.
What’s going on here? Note that 0L is a valid timestamp!
Collaborator
Author
There was a problem hiding this comment.
Early cancel. I've updated and commented, preferring a masking variable that is immutable to startNs?.run or similar.
| } | ||
|
|
||
| client.connectionPool().evictAll(); | ||
| if (client.connectionPool().connectionCount() > 0) { |
Collaborator
There was a problem hiding this comment.
Move this to OkHttpClientTestRule.ensureAllConnectionsReleased()
Collaborator
There was a problem hiding this comment.
... actually it has an assertion for this. Maybe replace that assertion with this?
| @After public void tearDown() throws InterruptedException { | ||
| clientListener.assertExhausted(); | ||
|
|
||
| client.connectionPool().evictAll(); |
Collaborator
There was a problem hiding this comment.
Same, this should be in OkHttpClientTestRule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6033
Assuming this is due to race conditions immediately after shutdown with websocket, allow for 500ms extra before failing. Will record which tests see delays, so we can query for this.