Limited support for decoding extensions#6145
Merged
swankjesse merged 1 commit intomasterfrom Jun 25, 2020
Merged
Conversation
Collaborator
|
This is looking really nice. |
swankjesse
force-pushed
the
jwilson.0625.extensions
branch
2 times, most recently
from
942744b to
ee9590e
Compare
swankjesse
force-pushed
the
jwilson.0625.extensions
branch
from
ee9590e to
a00cfbe
Compare
oldergod
approved these changes
Jun 25, 2020
| * by the current type's members. | ||
| */ | ||
| fun pushTypeHint() { | ||
| typeHintStack.add(null) |
Member
There was a problem hiding this comment.
is this a TODO? Why do you keep a stack of nulls?
Collaborator
Author
There was a problem hiding this comment.
I need to grow the stack so I have a place to put something later. It also obscures whatever value is currently at the top of the stack, which is necessary to prevent namespace pollution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.