Adopt Punycode in HttpUrl on non-JVM platforms#7805
Merged
swankjesse merged 2 commits intomasterfrom May 8, 2023
Merged
Conversation
swankjesse
force-pushed
the
jwilson.0507.hook_up_punycode
branch
from
779e4b8 to
0770155
Compare
yschimke
approved these changes
May 7, 2023
Collaborator
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
LGTM
Take it with a grain of salt, few beers in watching arsenal game with my son.
| val result = idnToAscii(host) ?: return null | ||
| if (result.isEmpty()) return null | ||
|
|
||
| return if (result.containsInvalidHostnameAsciiCodes()) { |
Collaborator
There was a problem hiding this comment.
Are these two check needed?
Or should be postconditions via check?
Collaborator
Author
There was a problem hiding this comment.
Yeah, they’re needed. Java’s IDN ToAscii returns non-ascii characters if it doesn’t have a mapping!
|
|
||
| @Test | ||
| fun hostnameLowercaseCharactersMappedDirectly() { | ||
| if (!isJvm) return // TODO: this test is broken on non-JVM platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.