Read response even if failed sending request headers #8759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new test class to simulate and handle socket failures during requests. This includes a scenario with large request headers and custom event listener to forcibly close sockets. The test ensures proper behavior under failure conditions. This reproduces square#8712
We should still read the response headers if so, since the error could be > 431 "Request Header Fields Too Large"
yschimke
changed the title
Collaborator
Author
|
@swankjesse requesting post-review |
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
May 5, 2025
* Handle failure while sending the request headers. We should still read the response headers if so, since the error could be > 431 "Request Header Fields Too Large" * Add SocketFailureTest to validate behavior on socket issues Introduce a new test class to simulate and handle socket failures during requests. This includes a scenario with large request headers and custom event listener to forcibly close sockets. The test ensures proper behavior under failure conditions. This reproduces square#8712 (cherry picked from commit 8fde8e9)
yschimke
added a commit
that referenced
this pull request
May 5, 2025
* Read response even if failed sending request headers (#8759) * Handle failure while sending the request headers. We should still read the response headers if so, since the error could be > 431 "Request Header Fields Too Large" * Add SocketFailureTest to validate behavior on socket issues Introduce a new test class to simulate and handle socket failures during requests. This includes a scenario with large request headers and custom event listener to forcibly close sockets. The test ensures proper behavior under failure conditions. This reproduces #8712 (cherry picked from commit 8fde8e9) * Fixes for 4.x branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle failure sending a large request such as
And try to read a response also.
Introduce a new test class to simulate and handle socket failures during requests. This includes a scenario with large request headers and custom event listener to forcibly close sockets. The test ensures proper behavior under failure conditions.
This reproduces #8712
The alternative fix would be to avoid reading a response when the request headers have not been successfully sent. But this wouldn't allow for receiving a 431 from the server.