Fix a binary-incompatible API change in Interceptor.Chain#9360
Merged
swankjesse merged 2 commits intomasterfrom Mar 10, 2026
Merged
Fix a binary-incompatible API change in Interceptor.Chain#9360swankjesse merged 2 commits intomasterfrom
swankjesse merged 2 commits intomasterfrom
Conversation
swankjesse
commented
Mar 10, 2026
Collaborator
Author
There was a problem hiding this comment.
@yschimke what’s the command to generate or validate this file? I couldn’t figure out how to run it.
Collaborator
Author
There was a problem hiding this comment.
This didn’t work for me. Did it regress with AGP 9 ?
rm -rf okhttp/api/android/okhttp.api
./gradlew apiDump
git diff HEAD
Collaborator
There was a problem hiding this comment.
apiCheck is working if I change something.
Collaborator
There was a problem hiding this comment.
apiDump is correctly reverting those changes.
Collaborator
Author
There was a problem hiding this comment.
I wonder what’s different between our environments....
$ ls $ANDROID_HOME
build-tools emulator fonts licenses ndk platform-tools platforms skins sources system-images
$ cat local.properties
sdk.dir=/Users/jessewilson/Library/Android/sdk
$ rm okhttp/api/android/okhttp.api
$ ./gradlew apiDump --rerun-tasks
...
BUILD SUCCESSFUL in 456ms
58 actionable tasks: 1 executed, 57 up-to-date
Configuration cache entry reused.
$ git status
On branch jwilson.0310.headers_limits
Your branch is up to date with 'origin/jwilson.0310.headers_limits'.
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
deleted: okhttp/api/android/okhttp.api
Collaborator
There was a problem hiding this comment.
Ooops, I was testing on the jvm file.
yschimke
approved these changes
Mar 10, 2026
I saw build flakes in CI on JDK8 without this
file:///home/runner/work/okhttp/okhttp/mockwebserver-deprecated/src/main/kotlin/okhttp3/mockwebserver/DeprecationBridge.kt:156:21
Symbol is declared in an unnamed module which is not read by current module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.