3.16.0 broken on Android TV 8.0 due to missing ClassValue class

[TRtomasz]

I'm trying to debug issue that some users of older TVs with older Android TVs version are reporting, i cant figure it out what is wrong. You can see the crash trace below. From the crash trace error is obvious it tries to use ClassValue which was added only recently. From what i see nothing has changed in the part of code in the last two years i wonder if this could be caused by the hardware vendor modifying the os.
From the user report this is the OS version

8.0.0, with the kernel being 3.10.79
Last security patch is from January 2021.

12-03 14:33:43.737  8928  8928 I zygote  : Deoptimizing java.lang.Object jp.co.cyberagent.lounge.LoungeController$collectModelBuildRequest$2.invokeSuspend(java.lang.Object) due to JIT inline cache
12-03 14:33:43.787  8928  9291 I zygote  : Rejecting re-init on previously-failed class java.lang.Class<kotlinx.coroutines.internal.ClassValueCtorCache$cache$1>: java.lang.NoClassDefFoundError: Failed resolution of: Ljava/lang/ClassValue;
12-03 14:33:43.787  8928  9291 I zygote  :   at boolean okio.NioSystemFileSystem$$ExternalSyntheticApiModelOutline0.m(java.nio.file.attribute.BasicFileAttributes) (D8$$SyntheticClass:0)
12-03 14:33:43.788  8928  9291 I zygote  :   at okio.FileMetadata okio.NioSystemFileSystem.metadataOrNull(java.nio.file.Path) (NioSystemFileSystem.kt:51)
12-03 14:33:43.788  8928  9291 I zygote  :   at okio.FileMetadata okio.NioSystemFileSystem.metadataOrNull(okio.Path) (NioSystemFileSystem.kt:35)
12-03 14:33:43.788  8928  9291 I zygote  :   at okio.FileMetadata okio.ForwardingFileSystem.metadataOrNull(okio.Path) (ForwardingFileSystem.kt:159)
12-03 14:33:43.788  8928  9291 I zygote  :   at boolean okio.internal.-FileSystem.commonExists(okio.FileSystem, okio.Path) (FileSystem.kt:41)
12-03 14:33:43.788  8928  9291 I zygote  :   at boolean okio.FileSystem.exists(okio.Path) (FileSystem.kt:41)
12-03 14:33:43.788  8928  9291 I zygote  :   at void okio.internal.-FileSystem.commonCreateDirectories(okio.FileSystem, okio.Path, boolean) (FileSystem.kt:49)
12-03 14:33:43.788  8928  9291 I zygote  :   at void okio.FileSystem.createDirectories(okio.Path, boolean) (FileSystem.kt:114)
12-03 14:33:43.788  8928  9291 I zygote  :   at void okio.FileSystem.createDirectories(okio.Path) (FileSystem.kt:117)
12-03 14:33:43.788  8928  9291 I zygote  :   at okio.Sink okhttp3.internal.cache.DiskLruCache$fileSystem$1.sink(okio.Path, boolean) (DiskLruCache.kt:108)
12-03 14:33:43.788  8928  9291 I zygote  :   at okio.Sink okio.FileSystem.sink(okio.Path) (FileSystem.kt:82)
12-03 14:33:43.788  8928  9291 I zygote  :   at boolean okhttp3.internal._UtilCommonKt.isCivilized(okio.FileSystem, okio.Path) (-UtilCommon.kt:303)
12-03 14:33:43.788  8928  9291 I zygote  :   at void okhttp3.internal.cache.DiskLruCache.initialize() (DiskLruCache.kt:246)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.internal.cache.DiskLruCache$Snapshot okhttp3.internal.cache.DiskLruCache.get(java.lang.String) (DiskLruCache.kt:453)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.Cache.get$okhttp(okhttp3.Request) (Cache.kt:197)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.cache.CacheInterceptor.intercept(okhttp3.Interceptor$Chain) (CacheInterceptor.kt:50)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.http.RealInterceptorChain.proceed(okhttp3.Request) (RealInterceptorChain.kt:126)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.http.BridgeInterceptor.intercept(okhttp3.Interceptor$Chain) (BridgeInterceptor.kt:85)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.http.RealInterceptorChain.proceed(okhttp3.Request) (RealInterceptorChain.kt:126)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(okhttp3.Interceptor$Chain) (RetryAndFollowUpInterceptor.kt:74)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.http.RealInterceptorChain.proceed(okhttp3.Request) (RealInterceptorChain.kt:126)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp() (RealCall.kt:208)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response okhttp3.internal.connection.RealCall.execute() (RealCall.kt:160)
12-03 14:33:43.788  8928  9291 I zygote  :   at okhttp3.Response com.squareup.picasso.UnsafeOkHttp3Downloader.load(okhttp3.Request) (UnsafeOkHttp3Downloader.kt:22)
12-03 14:33:43.788  8928  9291 I zygote  :   at com.squareup.picasso.RequestHandler$Result com.squareup.picasso.NetworkRequestHandler.load(com.squareup.picasso.Request, int) (NetworkRequestHandler.java:46)
12-03 14:33:43.788  8928  9291 I zygote  :   at android.graphics.Bitmap com.squareup.picasso.BitmapHunter.hunt() (BitmapHunter.java:219)
12-03 14:33:43.788  8928  9291 I zygote  :   at void com.squareup.picasso.BitmapHunter.run() (BitmapHunter.java:175)
12-03 14:33:43.788  8928  9291 I zygote  :   at java.lang.Object java.util.concurrent.Executors$RunnableAdapter.call() (Executors.java:457)
12-03 14:33:43.788  8928  9291 I zygote  :   at void java.util.concurrent.FutureTask.run() (FutureTask.java:266)
12-03 14:33:43.788  8928  9291 I zygote  :   at void java.util.concurrent.ThreadPoolExecutor.runWorker(java.util.concurrent.ThreadPoolExecutor$Worker) (ThreadPoolExecutor.java:1162)
12-03 14:33:43.788  8928  9291 I zygote  :   at void java.util.concurrent.ThreadPoolExecutor$Worker.run() (ThreadPoolExecutor.java:636)
12-03 14:33:43.788  8928  9291 I zygote  :   at void java.lang.Thread.run() (Thread.java:764)
12-03 14:33:43.788  8928  9291 I zygote  :   at void com.squareup.picasso.Utils$PicassoThread.run() (Utils.java:354)

[swankjesse]

Our code attempts to detect if java.nio is present by doing this:

      try {
        Class.forName("java.nio.file.Files")
        return@run NioSystemFileSystem()
      } catch (e: ClassNotFoundException) {
        return@run JvmSystemFileSystem()
      }

My guess is we’re finding the Files class, but we’re on a platform that doesn’t have a complete NIO implementation.

The fix will be for Okio to implement a better heuristic to detect if NIO is available.

Any information you can give me on the impacted devices would be handy. I’d love to try to repro it in an emulator or something!

[JakeWharton]

Okio is not the problem here. The stacktrace is misleading.

It indicates that the Okio call is going into a outlined class which was created by D8/R8 (through de-duplication of code), and that is triggering classloading of kotlinx.coroutines.internal.ClassValueCtorCache$cache$1 which is the offending reference of java.lang.ClassValue: https://github.com/Kotlin/kotlinx.coroutines/blob/5d4954b17ac18c572e22a9a6e7bb4e4368ec568c/kotlinx-coroutines-core/jvm/src/internal/ExceptionsConstructor.kt#L103.

[JakeWharton]

I would try adding something like -keep,allowobfuscation kotlinx.coroutines.internal.ClassValueCtorCache to your shrinker rules. Although if you're not using R8 and it's only D8 which is outlining the code... that's a larger problem.

[TRtomasz]

Yes, @JakeWharton we are not using r8 at all at the moment

[JakeWharton]

Can you send me the APK (my email is on my profile)? Or if not, can you open the APK directly in Android Studio, highlight the dex files, and then in the pane below navigate to the okio/NioSystemFileSystem$$ExternalSyntheticApiModelOutline0 class, right click, and select "Show Bytecode" and send all that text?

I'm filing an issue on D8 for this, but I'm having a hard time seeing exactly what it has outlined into that class between our function and the kotlinx.coroutines function.

[TRtomasz]

@JakeWharton done!

[JakeWharton]

Thanks! I have created a bug upstream here: https://issuetracker.google.com/issues/466978531

I will follow along there, and hope you do, too. I reviewed the bytecode before attaching and it's all harmless and doesn't contain any of your code. However, they might ask for an APK or for additional clarifications so keep an eye out for that.

[sgjesse]

Hi @TRtomasz, will it be possible for you to follow up on https://issuetracker.google.com/issues/466978531#comment3, I have a few questions for you there.