Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

Instantiate empty config map in GetConfig() if necessary#357

Merged
mpuncel merged 1 commit intosquare:masterfrom
mpuncel:mpuncel/dont-return-nil-config
Jan 4, 2016
Merged

Instantiate empty config map in GetConfig() if necessary#357
mpuncel merged 1 commit intosquare:masterfrom
mpuncel:mpuncel/dont-return-nil-config

Conversation

@mpuncel
Copy link
Collaborator

@mpuncel mpuncel commented Dec 23, 2015

This is for convenience so that callers modifying a manifest's config do
not need to check if it is nil before doing so

@anthonybishopric
Copy link
Contributor

👍

@bwester
Copy link
Member

bwester commented Jan 4, 2016

🚢

This is for convenience so that callers modifying a manifest's config do
not need to check if it is nil before doing so
@mpuncel mpuncel force-pushed the mpuncel/dont-return-nil-config branch from f4c2784 to 6e764ad Compare January 4, 2016 17:25
mpuncel added a commit that referenced this pull request Jan 4, 2016
Instantiate empty config map in GetConfig() if necessary
@mpuncel mpuncel merged commit 3b32ef8 into square:master Jan 4, 2016
@mpuncel mpuncel deleted the mpuncel/dont-return-nil-config branch January 28, 2016 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments