Load resources from another package#290
Closed
slvn wants to merge 7 commits intosquare:masterfrom
slvn:load-from-package
Closed
Load resources from another package#290slvn wants to merge 7 commits intosquare:masterfrom slvn:load-from-package
slvn wants to merge 7 commits intosquare:masterfrom
slvn:load-from-package
Conversation
- Add a parameter "resourcePackage" almost everywhere - Load Resource from PackageManager if a package is specified - throw an IOException if package cannot be found Tests are up to date.
Seems to be an issue in master as well.
Collaborator
|
Why didn't you just use a |
Author
|
Using package and id seems simpler, but as I am not satisfied with the API changes, using Uri can be better with less impact on code base. I did the modifications but I will make it cleaner (and remove my, now, useless code) when i got time and push it. Thanks. |
Author
|
This pull request can be closed as another one with better implementation has been pushed. Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to build a launcher, i was looking for loading icons from other applications. I did not find a way to do this using picasso, so paf, here it is.
I have to deactivate a test, but it seems to be linked with my dev environment. No test for this improvement so far.
If you think this could be useful, do not hesitate to review and post remarks, i can work/rework on it. I'm not 100% satisfied with my current APIs, so if you have any suggestion...