Skip to content

test: fix windows init test on 32-bit runners#260

Merged
hkpeprah merged 1 commit intosquare:masterfrom
lweyrich1:fix/windows-test-maxsize
Feb 22, 2026
Merged

test: fix windows init test on 32-bit runners#260
hkpeprah merged 1 commit intosquare:masterfrom
lweyrich1:fix/windows-test-maxsize

Conversation

@lweyrich1
Copy link
Contributor

Fixes #256

Problem

TestLibrary.test_initialize_windows assumes a 64-bit Python runtime, but it only patches sys.platform. On 32-bit runners (e.g. Arch Linux ARM 32-bit), sys.maxsize indicates 32-bit and the code correctly selects JLinkARM instead of JLink_x64, causing the test to fail.

Solution

Patch sys.maxsize in the 64-bit Windows test to explicitly model the intended runtime. The 32-bit variant is already covered by test_initialize_windows_32bit.

Testing

PYTHONPATH=. python -m unittest -q

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@hkpeprah hkpeprah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hkpeprah hkpeprah merged commit e8f9359 into square:master Feb 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestLibrary.test_initialize_windows fails on Arch Linux ARM 32-bit

3 participants