Add support for yearly event with bymonthday#69
Merged
nerdrew merged 1 commit intosquare:masterfrom Oct 20, 2025
Merged
Conversation
|
howdy @rmitchell-sq do you mind considering this? |
nerdrew
approved these changes
Oct 20, 2025
Collaborator
|
Thanks for the contribution! This has been released as 0.7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating this gem, we at TRMNL are currently using this gem in production.
While debugging a user reported issue, I noticed that the gem currently doesn't handle birthday events properly (eg:
RRULE:FREQ=YEARLY;BYMONTHDAY=01) from Fastmail calendar. This PR attempts to fix just that.