callBack to modify the bitmaps before saving them

[Lakedaemon]

Could we please have a callback allowing us to modify bitmaps before saving them to the device ?
It can be done by passing an interface and hacking the following method in Spoon

private static void takeScreenshot(File file, final Activity activity, final Callback callback) throws IOException {
    View view = activity.getWindow().getDecorView();
    final Bitmap bitmap = Bitmap.createBitmap(view.getWidth(), view.getHeight(), Config.ARGB_8888);
    if(Looper.myLooper() == Looper.getMainLooper()) {
        drawDecorViewToBitmap(activity, bitmap);
    } else {
        final CountDownLatch fos = new CountDownLatch(1);
        activity.runOnUiThread(new Runnable() {
            public void run() {
                try {
                    Spoon2.drawDecorViewToBitmap(activity, bitmap);
                } finally {
                    fos.countDown();
                }

            }
        });

        try {
            fos.await();
        } catch (InterruptedException var10) {
            String msg = "Unable to get screenshot " + file.getAbsolutePath();
            Log.e("Spoon", msg, var10);
            throw new RuntimeException(msg, var10);
        }
    }

    callback.peek(bitmap);  // user modifications there

    BufferedOutputStream fos1 = null;

    try {
        fos1 = new BufferedOutputStream(new FileOutputStream(file));
        bitmap.compress(CompressFormat.PNG, 100, fos1);
        Chmod.chmodPlusR(file);
    } finally {
        bitmap.recycle();
        if(fos1 != null) {
            fos1.close();
        }

    }

}

[JakeWharton]

Why do you need this?

On Sun, Apr 5, 2015, 4:45 AM Olivier Binda notifications@github.com wrote:

Could we please have a callback allowing us to modify bitmaps before
saving them to the device ?
It can be done by passing an interface and hacking the following method in
Spoon

private static void takeScreenshot(File file, final Activity activity, final Callback callback) throws IOException {
View view = activity.getWindow().getDecorView();
final Bitmap bitmap = Bitmap.createBitmap(view.getWidth(), view.getHeight(), Config.ARGB_8888);
if(Looper.myLooper() == Looper.getMainLooper()) {
drawDecorViewToBitmap(activity, bitmap);
} else {
final CountDownLatch fos = new CountDownLatch(1);
activity.runOnUiThread(new Runnable() {
public void run() {
try {
Spoon2.drawDecorViewToBitmap(activity, bitmap);
} finally {
fos.countDown();
}

        }
    });

    try {
        fos.await();
    } catch (InterruptedException var10) {
        String msg = "Unable to get screenshot " + file.getAbsolutePath();
        Log.e("Spoon", msg, var10);
        throw new RuntimeException(msg, var10);
    }
}

callback.peek(bitmap);  // user modifications there

BufferedOutputStream fos1 = null;

try {
    fos1 = new BufferedOutputStream(new FileOutputStream(file));
    bitmap.compress(CompressFormat.PNG, 100, fos1);
    Chmod.chmodPlusR(file);
} finally {
    bitmap.recycle();
    if(fos1 != null) {
        fos1.close();
    }

}

}

—
Reply to this email directly or view it on GitHub
#261.

[Lakedaemon]

I use spoon and expresso for 2 purposes :

1. to test my app
2. to create screenshots/gifs with localized (in 30+ languages) captions/highlights/watermark on various screens for marketting and documentation purposes

Marketting/Business : In my opinion, a screnshot that depicts concretely a feature is better at convincing an user to download an App or buy a premium inApp upgrade than app descriptions, with a list of abstract features.
-> more money

It's quite easy to create such a screenshot in spoon : you take the screenshot, put it in a canvas,
paint on it with localized strings and save the bitmap, spoon fetch it for you, and you can publish the result on GooglePlay, Amazon, SamsungApps, Yandex.Store....

Documentation : users of my app usually don't realize all features my app have (it's complex).
By showing them a picture (or a gif/video) of the feature in action, they can understand it more easily
-> more good reviews -> more downloads

Also, by watermarking screenshots, if they become widespread (facebook publication...)
you could in a way gain publicity (or have an edge on pirated version of your app ?)

[f2prateek]

Why not do the those transformations on your computer after the tests have been run and Spoon has pulled those images? Unless you need some information from the device itself to add your screenshots, you'll have more choices to customize them on a desktop/laptop than on a phone.

[Lakedaemon]

It can be done, for sure.

I chose to do it that way because it was easier :
In spoon/expresso, I have access to some internal variables for each screen :
theme, premium or free, languages configuration (any sublist in a set of 50 languages), locale, width, height, density
Also, accessing localized strings and drawing through a canva is also very easy.
Everything can be done in java with a few lines of code.

Now, if I had to do that on the desktop, I would have to pull the screenshots from spoon and export those variables (linked to the screenshots), the localized strings and then call a java library or an external program to watermark the pictures.

There might be other uses for getting early access to the bitmaps (visual tests).
Like failing a test fast because two bitmaps aren't the same.... But I'm not doing that. ^^