This repository was archived by the owner on Aug 17, 2020. It is now read-only.
mapToOneOrNull replaced by mapToOneOrDefault#56
Merged
JakeWharton merged 1 commit intosquare:masterfrom Sep 9, 2015
phajduk:added-maptooneordefault
Merged
mapToOneOrNull replaced by mapToOneOrDefault#56JakeWharton merged 1 commit intosquare:masterfrom phajduk:added-maptooneordefault
JakeWharton merged 1 commit intosquare:masterfrom
phajduk:added-maptooneordefault
Conversation
Collaborator
There was a problem hiding this comment.
You still need this boolean but it should probably be called emitDefault. null is a valid default value and right now there's no way to emit it.
Contributor
Author
There was a problem hiding this comment.
We can still emit null by passing it to the mapToOneOrDefault method (null passed as a second argument). Eventually, there could be two methods mapToOneOrDefault and mapToOneOrNull as it was previously.
Collaborator
There was a problem hiding this comment.
But then you break mapToOne which does not emit anything on empty.
Collaborator
|
Can you squash to one commit? If not, I can do it upon merge. |
Contributor
Author
|
Squashed. |
JakeWharton
added a commit
that referenced
this pull request
Sep 9, 2015
mapToOneOrNull replaced by mapToOneOrDefault
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #55