Redacted Kotlin scalars respect nullability#1977
Merged
oldergod merged 3 commits intoJun 2, 2021
Merged
Conversation
oldergod
reviewed
May 28, 2021
| return when { | ||
| isRepeated -> CodeBlock.of("emptyList()") | ||
| isMap -> CodeBlock.of("emptyMap()") | ||
| isOptional || isOneOf -> CodeBlock.of("null") |
Member
There was a problem hiding this comment.
Is there an existing test case for one ofs?
Member
There was a problem hiding this comment.
Also could we look at Field.EncodeMode.NULL_IF_ABSENT instead?
Contributor
Author
There was a problem hiding this comment.
Hrmm not for this use case. I've updated the included test to cover redacted one ofs and switched over to Field.EncodeMode.NULL_IF_ABSENT as well, thanks.
oldergod
force-pushed
the
redacted-kotlin-scalars-fix
branch
from
0c2ccee to
3cf2743
Compare
MehdiAghajani
pushed a commit
to MehdiAghajani/wire
that referenced
this pull request
Dec 26, 2021
* kotlin redacted scalars fix * Field.EncodeMode used to determine redacted field value * Tests for message Co-authored-by: Benoit Quenaudon <bquenaudon@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR
KotlinGeneratorwas generating invalid code for redacted proto3 scalars. For example:With this change, non-nullable Kotlin scalar values are redacted as the identity value for the given type.