Include oneOfs in constructorTakesAllFields() and fix null check in generateOptionType #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunofrts
commented
Apr 29, 2025
| + " int32 foo = 257;\n" | ||
| + " int32 bar = 258;\n" | ||
| + " }\n" | ||
| + " oneof oneof_name {\n" |
Collaborator
Author
There was a problem hiding this comment.
Only fixed indentation for this test, diff looks a bit odd due to next (new) test using the same assert.
oldergod
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs
constructorTakesAllFields()did not take into account the fact that each field in aoneOfcontributes to the parameter list in the constructor. This makes it impossible to compile messages with very long oneOfs since Java limits parameter lists to 255 elements.generateOptionType, so unlabeled fields would trigger a NPE. The comparison order has been flipped to avoid this.The two tests introduced fail in the previous build.